Navigation: Add 'edit' to the block toolbar #45853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
requested review from
draganescu,
youknowriad,
getdave and
jasmussen
|
|
|
Size Change: +91 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
|
I tested and this doesn't seem to be working. Did all changes get pushed? |
getdave
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
I tested this and it works 🎉
Some feedback from a UX perspective which we can iterate on in followups.
- We should try and focus the
Menupanel whenEditis clicked. - Having
Editremain active when the sidebar is open feels strange. Maybe it should be disabled? Something about the interaction doesn't feel right to me.
Overall though this now works well and avoids the pitfalls of the other approach.
I have some questions about string literals but I'd need to defer to others on whether the approach is valid or not.
We should get 👍 from @youknowriad before merging this one.
| isPostEditor, | ||
| } = useSelect( | ||
| ( select ) => { | ||
| // eslint-disable-next-line @wordpress/data-no-store-string-literals |
There was a problem hiding this comment.
Is it ok to use string literals here then?
Comment on lines
+36
to
+42
| const openBlockInspector = () => { | ||
| if ( isPostEditor ) { | ||
| openGeneralSidebar( 'edit-post/block' ); | ||
| } else { | ||
| enableComplementaryArea( 'core/edit-site', 'edit-site/block-inspector' ); | ||
| } | ||
| }; |
There was a problem hiding this comment.
It feels like we should either have:
- normalized the structure of the editors
- create an abstraction to handle this kind of stuff
Not for this PR though...
|
@scruffian You should get 👍 from @youknowriad before merging this one. |
youknowriad
reviewed
Nov 18, 2022
| // We use this to determine which editor we are in so that | ||
| // we can determine which inspector controls to open. | ||
| const { | ||
| isPostEditor, |
There was a problem hiding this comment.
There's no need to test isPostEditor, we're always in post editor here, since this plugin is defined in edit-post
There was a problem hiding this comment.
In my testing, this was also running in the site editor.
youknowriad
reviewed
Nov 18, 2022
scruffian
force-pushed
the
update/navigation-edit-option
branch
from
f62d66e to
532daa5
Compare
scruffian
force-pushed
the
update/navigation-edit-option
branch
from
532daa5 to
9cbe8ac
Compare
|
What are the next steps here? |
I think we should probably start afresh. My current thinking is that we should change the list view button in the edit-side component to open the block inspector controls, and add the same thing to edit-post. |
|
Closing in favour of #46335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This adds an "Edit" button the Block Toolbar for the navigation block, which opens the inspector controls.
Why?
An alternative to #45772.
How?
Adds a new plugin to the edit-post package and modifies the edit-site package.
Testing Instructions
Screenshots or screencast
TODO